fix(tools): resolve Windows build errors and harden filesystem security#318
Merged
viettranx merged 2 commits intonextlevelbuilder:mainfrom Mar 21, 2026
Merged
Conversation
Now that checkHardlink uses GetFileInformationByHandle on Windows, the test should run on all platforms.
duhd-vnpay
added a commit
to duhd-vnpay/goclaw
that referenced
this pull request
Mar 21, 2026
…Azure OpenAI Upstream changes (v1.68.1 → v1.74.1, 17 commits): - feat: pgvector semantic search for KG entities + team KG sharing - feat: extractive memory fallback when LLM flush fails - feat: Azure OpenAI + Foundry header support (nextlevelbuilder#319) - fix: YAML multiline skill frontmatter parsing (nextlevelbuilder#325) - fix: skills DB file_path directory resolution (nextlevelbuilder#322) - fix: MCP OpenAI compatibility (nextlevelbuilder#321) - fix: Windows build + filesystem security (nextlevelbuilder#318) - feat: MediaMaxBytes enforcement for Telegram/Discord (nextlevelbuilder#317) - fix: memory embedding cache reliability - fix: UI usage tab crash, image download overlay - fix: teams post-turn processor + PendingTeamDispatch Conflicts resolved: - internal/agent/loop.go: take upstream (no local changes) - internal/tools/filesystem.go: take upstream (our comment moved) - internal/upgrade/version.go: keep ours (28 > upstream 25) - Removed old filesystem_{unix,windows}.go (replaced by filesystem_security_{unix,windows}.go upstream) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GoClaw currently fails to build on native Windows because it uses Unix-specific
syscall.Accessandsyscall.Stat_tAPIs ininternal/tools/filesystem.go. A previous attempt at fixing this (PR #132) correctly identified the "build tag" approach but introduced several security and efficiency regressions on Windows, such as bypassing the hardlink check and creating unnecessary temporary files on disk.What This PR Fixes
This PR provides a clean, platform-separated implementation that resolves the build errors while addressing all critical feedback from the previous maintainer review:
Unlike the previous no-op implementation, this PR uses
syscall.GetFileInformationByHandleto fetchNumberOfLinkson Windows. This ensures that hardlink-based escapes (e.g., trying to read an absolute file via a hardlink inside the workspace) are correctly blocked on Windows, matching the security parity of Linux.Replaced the brittle
strings.Splitlogic with afilepath.Dirtraversal loop. This correctly handles volume roots (C:) and network UNC paths (\server\share), ensuring the security scanner always has a valid absolute path for each component.To be honest I was just annoyed that I couldn't build and saw that someone had tried to fix this issue before but went missing so I decided to continue their work